-
Notifications
You must be signed in to change notification settings - Fork 25
ZKP-43 Implement serde_deprecated flag for concordium-base repo #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae9942b to
966b6cd
Compare
966b6cd to
07508c6
Compare
allanbrondum
reviewed
Jan 6, 2026
allanbrondum
reviewed
Jan 6, 2026
allanbrondum
reviewed
Jan 6, 2026
allanbrondum
reviewed
Jan 6, 2026
allanbrondum
reviewed
Jan 6, 2026
rust-src/concordium_base/src/protocol_level_tokens/token_metadata_url.rs
Outdated
Show resolved
Hide resolved
allanbrondum
reviewed
Jan 6, 2026
rust-src/concordium_base/src/protocol_level_tokens/token_metadata_url.rs
Outdated
Show resolved
Hide resolved
allanbrondum
reviewed
Jan 6, 2026
allanbrondum
reviewed
Jan 6, 2026
allanbrondum
requested changes
Jan 6, 2026
Contributor
allanbrondum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good
a42a040 to
e5928f6
Compare
e5928f6 to
6bed6d3
Compare
Member
|
The CI pipeline now tests that the |
allanbrondum
approved these changes
Jan 19, 2026
Remove unused error files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sub task of ZKP-41. To eventually deprecate use of
serdeon non primitive data types.Changes
Guard non primitive
serde::Serialize, serde::Deserializebehind a flag. List of data types can be found hereChecklist
hard-to-understand areas.