Skip to content

Conversation

@AHaliq
Copy link
Contributor

@AHaliq AHaliq commented Dec 19, 2025

Purpose

Sub task of ZKP-41. To eventually deprecate use of serde on non primitive data types.

Changes

Guard non primitive serde::Serialize, serde::Deserialize behind a flag. List of data types can be found here

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@AHaliq AHaliq requested a review from allanbrondum December 19, 2025 11:56
@AHaliq AHaliq added [Type] Maintenance Cleanup or handling of technical debt. backlog labels Dec 19, 2025
@AHaliq AHaliq force-pushed the haliq/serde-deprecated branch from ae9942b to 966b6cd Compare December 22, 2025 16:44
@AHaliq AHaliq force-pushed the haliq/serde-deprecated branch from 966b6cd to 07508c6 Compare December 22, 2025 16:49
@AHaliq AHaliq marked this pull request as ready for review December 22, 2025 17:20
Copy link
Contributor

@allanbrondum allanbrondum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good

@DOBEN DOBEN force-pushed the haliq/serde-deprecated branch from a42a040 to e5928f6 Compare January 16, 2026 18:49
@DOBEN DOBEN force-pushed the haliq/serde-deprecated branch from e5928f6 to 6bed6d3 Compare January 19, 2026 09:07
@DOBEN DOBEN requested a review from allanbrondum January 19, 2026 10:35
@DOBEN
Copy link
Member

DOBEN commented Jan 19, 2026

The CI pipeline now tests that the serde_deprecate feature can be disabled.

@DOBEN DOBEN mentioned this pull request Jan 19, 2026
@DOBEN DOBEN merged commit b26f818 into main Jan 19, 2026
40 checks passed
@DOBEN DOBEN deleted the haliq/serde-deprecated branch January 19, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog [Type] Maintenance Cleanup or handling of technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants